lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1cce5a11-f182-04b0-0aa3-ed27614a564d@linaro.org> Date: Tue, 30 May 2023 16:04:03 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Oleksij Rempel <o.rempel@...gutronix.de>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Jérôme Pouiller <jerome.pouiller@...abs.com> Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: net: pse-pd: Update regex pattern for ethernet-pse nodes On 30/05/2023 10:37, Oleksij Rempel wrote: > This patch modifies the regex pattern for the $nodename property in the Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > device tree bindings documentation for PSE-PD controllers. The updated > pattern allows for additional node names, including those with a hyphen > followed by a hexadecimal digit. > > Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for > node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern > node names like "ethernet-pse-1" are now also valid. This part is duplicating first paragraph. What you should have here is answer to why we need it. > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de> > --- > .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > index b110abb42597..3548efc2191c 100644 > --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > @@ -16,7 +16,7 @@ maintainers: > > properties: > $nodename: > - pattern: "^ethernet-pse(@.*)?$" > + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" No need for inner () Let's make -N suffix only decimal, as discussed here: https://lore.kernel.org/all/20221123024153.GB1026269-robh@kernel.org/ I will send a patch for other files. > > "#pse-cells": > description: Best regards, Krzysztof
Powered by blists - more mailing lists