lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b4940bfa-aab6-644a-77d3-20bf9a876a6a@kernel.org> Date: Tue, 30 May 2023 09:25:30 -0600 From: David Ahern <dsahern@...nel.org> To: Parav Pandit <parav@...dia.com>, edumazet@...gle.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: Make gro complete function to return void On 5/29/23 7:44 AM, Parav Pandit wrote: > diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c > index 45dda7889387..88f9b0081ee7 100644 > --- a/net/ipv4/tcp_offload.c > +++ b/net/ipv4/tcp_offload.c > @@ -296,7 +296,7 @@ struct sk_buff *tcp_gro_receive(struct list_head *head, struct sk_buff *skb) > return pp; > } > > -int tcp_gro_complete(struct sk_buff *skb) > +void tcp_gro_complete(struct sk_buff *skb) > { > struct tcphdr *th = tcp_hdr(skb); > > @@ -311,8 +311,6 @@ int tcp_gro_complete(struct sk_buff *skb) > > if (skb->encapsulation) > skb->inner_transport_header = skb->transport_header; > - > - return 0; > } > EXPORT_SYMBOL(tcp_gro_complete); tcp_gro_complete seems fairly trivial. Any reason not to make it an inline and avoid another function call in the datapath? > > @@ -342,7 +340,8 @@ INDIRECT_CALLABLE_SCOPE int tcp4_gro_complete(struct sk_buff *skb, int thoff) > if (NAPI_GRO_CB(skb)->is_atomic) > skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_FIXEDID; > > - return tcp_gro_complete(skb); > + tcp_gro_complete(skb); > + return 0; > } >
Powered by blists - more mailing lists