netdev - Re: [PATCH net-next] net: Make gro complete function to return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHWphd6hL+dccyVm@corigine.com>
Date: Tue, 30 May 2023 09:45:09 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Parav Pandit <parav@...dia.com>
Cc: edumazet@...gle.com, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Make gro complete function to return void

On Mon, May 29, 2023 at 04:44:30PM +0300, Parav Pandit wrote:
> tcp_gro_complete() function only updates the skb fields related to GRO
> and it always returns zero. All the 3 drivers which are using it
> do not check for the return value either.
> 
> Change it to return void instead which simplifies its callers as
> error handing becomes unnecessary.
> 
> Signed-off-by: Parav Pandit <parav@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>