lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <038901d992bd$863a6b30$92af4190$@trustnetic.com> Date: Tue, 30 May 2023 14:11:08 +0800 From: Jiawen Wu <jiawenwu@...stnetic.com> To: "'Andy Shevchenko'" <andriy.shevchenko@...ux.intel.com>, "'Hans de Goede'" <hdegoede@...hat.com> Cc: <netdev@...r.kernel.org>, <jarkko.nikula@...ux.intel.com>, <mika.westerberg@...ux.intel.com>, <jsd@...ihalf.com>, <Jose.Abreu@...opsys.com>, <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <linux-i2c@...r.kernel.org>, <linux-gpio@...r.kernel.org>, <mengyuanlou@...-swift.com>, "'Piotr Raczynski'" <piotr.raczynski@...el.com> Subject: RE: [PATCH net-next v9 1/9] net: txgbe: Add software nodes to support phylink On Saturday, May 27, 2023 4:44 PM, Andy Shevchenko wrote: > +Cc Hans (see below) > > On Wed, May 24, 2023 at 05:17:14PM +0800, Jiawen Wu wrote: > > Register software nodes for GPIO, I2C, SFP and PHYLINK. Define the > > device properties. > > ... > > > +int txgbe_init_phy(struct txgbe *txgbe) > > +{ > > + int ret; > > + > > + ret = txgbe_swnodes_register(txgbe); > > + if (ret) { > > + wx_err(txgbe->wx, "failed to register software nodes\n"); > > > + return ret; > > + } > > + > > + return 0; > > These 4 lines can be as simple as > > return ret; This function is going to be extended with later patches, is it necessary to simply it here? > > > +} > > ... > > > +#define NODE_PROP(_NAME, _PROP) \ > > + (const struct software_node) { \ > > + .name = _NAME, \ > > + .properties = _PROP, \ > > + } > > Looking at the amount of drivers that want this, I would declare it in the > property.h with SOFTWARE_NODE_PROPERTY name. I'll Ack that. > > Hans, what do you think?
Powered by blists - more mailing lists