netdev - Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rd5v49t.fsf@intel.com>
Date: Tue, 30 May 2023 15:33:02 -0700
From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Kurt Kanzenbach
 <kurt@...utronix.de>, Gerhard Engleder <gerhard@...leder-embedded.com>,
 Amritha Nambiar <amritha.nambiar@...el.com>, Ferenc Fejes
 <ferenc.fejes@...csson.com>, Xiaoliang Yang <xiaoliang.yang_1@....com>,
 Roger Quadros <rogerq@...nel.org>, Pranavi Somisetty
 <pranavi.somisetty@....com>, Harini Katakam <harini.katakam@....com>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Michael Sit Wei Hong
 <michael.wei.hong.sit@...el.com>, Mohammad Athari Bin Ismail
 <mohammad.athari.ismail@...el.com>, Oleksij Rempel
 <linux@...pel-privat.de>, Jacob Keller <jacob.e.keller@...el.com>,
 linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Florian
 Fainelli <f.fainelli@...il.com>, Claudiu Manoil <claudiu.manoil@....com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 UNGLinuxDriver@...rochip.com, Jesse
 Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Horatiu Vultur
 <horatiu.vultur@...rochip.com>, Jose Abreu <joabreu@...opsys.com>, Maxime
 Coquelin <mcoquelin.stm32@...il.com>, intel-wired-lan@...ts.osuosl.org,
 Muhammad
 Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>
Subject: Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch"
 variable in taprio_dump_class_stats()

Vladimir Oltean <vladimir.oltean@....com> writes:

> On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote:
>> But I have a suggestion, this "taprio_queue_get() ->
>> dev_queue->qdisc_sleeping()" dance should have the same result as
>> calling 'taprio_leaf()'.
>> 
>> I am thinking of using taprio_leaf() here and in taprio_dump_class().
>> Could be a separate commit.
>
> Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern.
> Since taprio_dump_class() could benefit from the consolidation too, they
> could really be both converted separately. Or I could also handle that
> in this patch set, if I need to resend it.

Exactly. Both options sound great.

Cheers,
-- 
Vinicius