netdev - Re: [PATCH net v4] tcp: fix mishandling when the sack compression is deferred.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <168561901927.15218.5820204567180741386.git-patchwork-notify@kernel.org>
Date: Thu, 01 Jun 2023 11:30:19 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: fuyuanli <fuyuanli@...iglobal.com>
Cc: edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org,
 kuba@...nel.org, pabeni@...hat.com, ncardwell@...gle.com, ycheng@...gle.com,
 toke@...e.dk, netdev@...r.kernel.org, zhangweiping@...iglobal.com,
 tiozhang@...iglobal.com, kerneljasonxing@...il.com
Subject: Re: [PATCH net v4] tcp: fix mishandling when the sack compression is
 deferred.

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 31 May 2023 16:01:50 +0800 you wrote:
> In this patch, we mainly try to handle sending a compressed ack
> correctly if it's deferred.
> 
> Here are more details in the old logic:
> When sack compression is triggered in the tcp_compressed_ack_kick(),
> if the sock is owned by user, it will set TCP_DELACK_TIMER_DEFERRED
> and then defer to the release cb phrase. Later once user releases
> the sock, tcp_delack_timer_handler() should send a ack as expected,
> which, however, cannot happen due to lack of ICSK_ACK_TIMER flag.
> Therefore, the receiver would not sent an ack until the sender's
> retransmission timeout. It definitely increases unnecessary latency.
> 
> [...]

Here is the summary with links:
  - [net,v4] tcp: fix mishandling when the sack compression is deferred.
    https://git.kernel.org/netdev/net/c/30c6f0bf9579

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html