netdev - Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy link status inversion property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc5cae94-effa-4246-85b8-8d3ec8fada66@lunn.ch>
Date: Thu, 1 Jun 2023 15:36:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Atsushi Nemoto <atsushi.nemoto@...d.co.jp>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>,
	Alexandru Tachici <alexandru.tachici@...log.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy
 link status inversion property

> But in this case, LINK_ST is also connected to MII_RXLINK pin of
> the MAC module in SoC. MII_RXLINK also expects low-active signal input.
> (though I only wrote about LED, sorry)

This is why the Commit message should contain the answer to 'Why?'.
The code tells us 'What', but without knowing the 'Why', it is hard to
say if you are doing the right or wrong thing.

O.K. so the signal is also connected to the SoC. Why? This is very
unusual. The MAC does not really care if there is link or not, it just
sends a bitstream to the PHY. phylib will be monitoring the PHY and
when it detects the link is down it will tell the MAC via the
adjust_link callback.

What SoC is this?

> AD1200/AD1200 have another LED_0 pin and it should be appropriate for
> the LED subsystem.

Agreed.

	Andrew