netdev - Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy link status inversion property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Jun 2023 22:16:57 +0900
From: Atsushi Nemoto <atsushi.nemoto@...d.co.jp>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 Michael Hennerich <michael.hennerich@...log.com>,
 Alexandru Tachici <alexandru.tachici@...log.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy
 link status inversion property

On 2023/06/01 21:28, Andrew Lunn wrote:
>>> Please could you add an explanation to the commit message why you
>>> would want to do this?  Is this because there is an LED connected to
>>> it, but its polarity is inverted?
>>
>> Yes, the LINK_ST pin of AD1200/1300 is active-high but our custom
>> board designer connected it to an LED as an active-low signal.
> 
> O.K. LED is the magic word here. And the fact that there is nothing
> specific to this PHY. Being able to specify the polarity of an output
> to an LED is pretty common.
> 
> Please take a look at:
> 
> ocumentation/devicetree/bindings/net/ethernet-phy.yaml

Thanks for your advice.

But in this case, LINK_ST is also connected to MII_RXLINK pin of
the MAC module in SoC. MII_RXLINK also expects low-active signal input.
(though I only wrote about LED, sorry)

AD1200/AD1200 have another LED_0 pin and it should be appropriate for
the LED subsystem.

So I still like to use this device specific property device.

---
Atsushi Nemoto