netdev - Re: [PATCH net-next 05/15] idpf: add create vport and netdev configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fe3bf2a-6cb2-c3a1-3fa3-ed9a5425e603@intel.com>
Date: Thu, 1 Jun 2023 16:47:58 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, <emil.s.tantilov@...el.com>,
	<jesse.brandeburg@...el.com>, <sridhar.samudrala@...el.com>,
	<shiraz.saleem@...el.com>, <sindhu.devale@...el.com>, <willemb@...gle.com>,
	<decot@...gle.com>, <andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, Alan Brady <alan.brady@...el.com>, Joshua Hay
	<joshua.a.hay@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, "Phani
 Burra" <phani.r.burra@...el.com>, Shailendra Bhatnagar
	<shailendra.bhatnagar@...el.com>, Krishneil Singh
	<krishneil.k.singh@...el.com>
Subject: Re: [PATCH net-next 05/15] idpf: add create vport and netdev
 configuration



On 5/31/2023 11:22 PM, Jakub Kicinski wrote:
> On Tue, 30 May 2023 16:44:51 -0700 Tony Nguyen wrote:
>> @@ -137,8 +210,12 @@ static int idpf_set_msg_pending_bit(struct idpf_adapter *adapter,
>>   	 * previous message.
>>   	 */
>>   	while (retries) {
>> -		if (!test_and_set_bit(IDPF_VC_MSG_PENDING, adapter->flags))
>> +		if ((vport && !test_and_set_bit(IDPF_VPORT_VC_MSG_PENDING,
>> +						vport->flags)) ||
>> +		    (!vport && !test_and_set_bit(IDPF_VC_MSG_PENDING,
>> +						 adapter->flags)))
>>   			break;
>> +
>>   		msleep(20);
>>   		retries--;
>>   	}
> 
> Please use locks. Every single Intel driver comes with gazillion flags
> and endless bugs when the flags go out of sync.

Thanks for the feedback. Will use mutex lock instead of 'VC_MSG_PENDING' 
flag.

Regards,
Pavan