netdev - Re: [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4f80b89-7804-4832-280e-3bd0c9501a3f@intel.com>
Date: Thu, 1 Jun 2023 16:40:34 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Joshua Hay <joshua.a.hay@...el.com>,
	<emil.s.tantilov@...el.com>, <jesse.brandeburg@...el.com>,
	<sridhar.samudrala@...el.com>, <shiraz.saleem@...el.com>,
	<sindhu.devale@...el.com>, <willemb@...gle.com>, <decot@...gle.com>,
	<andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>, <linux-doc@...r.kernel.org>, Alan Brady
	<alan.brady@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, Phani Burra
	<phani.r.burra@...el.com>, Krishneil Singh <krishneil.k.singh@...el.com>
Subject: Re: [PATCH net-next 15/15] idpf: configure SRIOV and add other
 ndo_ops



On 5/31/2023 11:23 PM, Jakub Kicinski wrote:
> On Tue, 30 May 2023 16:45:01 -0700 Tony Nguyen wrote:
>> +	struct idpf_vport *vport = idpf_netdev_to_vport(netdev);
>> +
>> +	if (!vport)
>> +		return;
>> +
>> +	*stats = vport->netstats;
> 
> How is this atomic vs the update path.

I see your point. 'vport->netstats' can go out of sync if the statistics 
task updates the 'netstats' concurrently. Will guard the stats update 
with a lock. Thanks for the review.

Regards,
Pavan