netdev - Re: [PATCH net 1/2] net: enetc: correct the statistics of rx bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230602103142.ryesgb7ykamtzxnx@skbuf>
Date: Fri, 2 Jun 2023 13:31:42 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: wei.fang@....com
Cc: claudiu.manoil@....com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, ast@...nel.org,
	daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: enetc: correct the statistics of rx bytes

On Fri, Jun 02, 2023 at 05:46:58PM +0800, wei.fang@....com wrote:
> From: Wei Fang <wei.fang@....com>
> 
> The rx_bytes of struct net_device_stats should count the length of
> ethernet frames excluding the FCS. However, there are two problems
> with the rx_bytes statistics of the current enetc driver. one is
> that the length of VLAN header is not counted if the VLAN extraction
> feature is enabled. The other is that the length of L2 header is not
> counted, because eth_type_trans() is invoked before updating rx_bytes
> which will subtract the length of L2 header from skb->len.
> BTW, the rx_bytes statistics of XDP path also have similar problem,
> I will fix it in another patch.
> 
> Fixes: a800abd3ecb9 ("net: enetc: move skb creation into enetc_build_skb")
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

By the way, you mangled Jakub's email (kuba@...nel.or) - I've fixed it up.