lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e67321c3-2a81-170a-0394-bdb00beb7182@prolan.hu>
Date: Mon, 5 Jun 2023 14:35:33 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: Marc Kleine-Budde <mkl@...gutronix.de>
CC: <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>, Richard Cochran
	<richardcochran@...il.com>, <kernel@...gutronix.de>, Jakub Kicinski
	<kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

On 2023. 06. 05. 11:51, Marc Kleine-Budde wrote:
> On 05.06.2023 11:44:03, Csókás Bence wrote:
>> Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>
> 
> You probably want to add a patch description.

Is it necessary for such a trivial refactor commit? I thought the commit 
msg already said it all. What else do you think I should include still?


Would something like this be sufficient?
"Rename local `struct fec_enet_private *adapter` to `fep` in 
`fec_ptp_gettime()` to match the rest of the driver"

> 
> regards,
> Marc
> 

Thanks,
Bence


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ