netdev - Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230605-majorette-reverse-996f5b76cd77-mkl@pengutronix.de>
Date: Mon, 5 Jun 2023 14:43:48 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Richard Cochran <richardcochran@...il.com>, kernel@...gutronix.de,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

On 05.06.2023 14:35:33, Csókás Bence wrote:
> On 2023. 06. 05. 11:51, Marc Kleine-Budde wrote:
> > On 05.06.2023 11:44:03, Csókás Bence wrote:
> > > Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>
> > 
> > You probably want to add a patch description.
> 
> Is it necessary for such a trivial refactor commit?

This is considered good practice.

> I thought the commit msg
> already said it all. What else do you think I should include still?
> 
> Would something like this be sufficient?
> "Rename local `struct fec_enet_private *adapter` to `fep` in
> `fec_ptp_gettime()` to match the rest of the driver"

Looks good to me.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)