netdev - Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Jun 2023 14:51:59 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Csókás Bence <csokas.bence@...lan.hu>,
 Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
 Richard Cochran <richardcochran@...il.com>, kernel@...gutronix.de,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

On 05.06.23 14:35, Csókás Bence wrote:
> On 2023. 06. 05. 11:51, Marc Kleine-Budde wrote:
>> On 05.06.2023 11:44:03, Csókás Bence wrote:
>>> Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>
>>
>> You probably want to add a patch description.
> 
> Is it necessary for such a trivial refactor commit? I thought the commit msg already said it all. What else do you think I should include still?
> 
> 
> Would something like this be sufficient?
> "Rename local `struct fec_enet_private *adapter` to `fep` in `fec_ptp_gettime()` to match the rest of the driver"

The "to match the rest of the driver" is the interesting part.
I see what the commit is doing, but the title alone doesn't tell
me why you'd want to change it.

Cheers,
Ahmad

> 
>>
>> regards,
>> Marc
>>
> 
> Thanks,
> Bence
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |