netdev - Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZH4pGitjMPiiGgE8@boxer>
Date: Mon, 5 Jun 2023 20:27:38 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Csókás Bence <csokas.bence@...lan.hu>
CC: <netdev@...r.kernel.org>, Richard Cochran <richardcochran@...il.com>,
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	<qiangqing.zhang@....com>, Andrew Lunn <andrew@...n.ch>,
	<kernel@...gutronix.de>
Subject: Re: [PATCH resubmit] net: fec: Refactor: rename `adapter` to `fep`

On Mon, Jun 05, 2023 at 11:44:03AM +0200, Csókás Bence wrote:

please provide a motivation behind this rename in the commit message.

> Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
> index ab86bb8562ef..afc658d2c271 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -443,21 +443,21 @@ static int fec_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta)
>   */
>  static int fec_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
>  {
> -	struct fec_enet_private *adapter =
> +	struct fec_enet_private *fep =
>  	    container_of(ptp, struct fec_enet_private, ptp_caps);
>  	u64 ns;
>  	unsigned long flags;
>  
> -	mutex_lock(&adapter->ptp_clk_mutex);
> +	mutex_lock(&fep->ptp_clk_mutex);
>  	/* Check the ptp clock */
> -	if (!adapter->ptp_clk_on) {
> -		mutex_unlock(&adapter->ptp_clk_mutex);
> +	if (!fep->ptp_clk_on) {
> +		mutex_unlock(&fep->ptp_clk_mutex);
>  		return -EINVAL;
>  	}
> -	spin_lock_irqsave(&adapter->tmreg_lock, flags);
> -	ns = timecounter_read(&adapter->tc);
> -	spin_unlock_irqrestore(&adapter->tmreg_lock, flags);
> -	mutex_unlock(&adapter->ptp_clk_mutex);
> +	spin_lock_irqsave(&fep->tmreg_lock, flags);
> +	ns = timecounter_read(&fep->tc);
> +	spin_unlock_irqrestore(&fep->tmreg_lock, flags);
> +	mutex_unlock(&fep->ptp_clk_mutex);
>  
>  	*ts = ns_to_timespec64(ns);
>  
> -- 
> 2.25.1
> 
> 
>