lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <TYBPR01MB5341ED437E01EBC646BCC85FD852A@TYBPR01MB5341.jpnprd01.prod.outlook.com> Date: Tue, 6 Jun 2023 08:59:21 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> To: Simon Horman <simon.horman@...igine.com> CC: "s.shtylyov@....ru" <s.shtylyov@....ru>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, "geert+renesas@...der.be" <geert+renesas@...der.be>, "magnus.damm@...il.com" <magnus.damm@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org> Subject: RE: [PATCH net-next 5/5] net: renesas: rswitch: Use per-queue rate limiter Hi Simon-san, > From: Simon Horman, Sent: Wednesday, May 31, 2023 4:29 AM > > On Mon, May 29, 2023 at 05:08:40PM +0900, Yoshihiro Shimoda wrote: > > Use per-queue rate limiter instead of global rate limiter. Otherwise > > TX performance will be low when we use multiple ports at the same time. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> > > --- > > drivers/net/ethernet/renesas/rswitch.c | 51 +++++++++++++++++--------- > > drivers/net/ethernet/renesas/rswitch.h | 15 +++++++- > > 2 files changed, 47 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c > > index 4ae34b0206cd..a7195625a2c7 100644 > > --- a/drivers/net/ethernet/renesas/rswitch.c > > +++ b/drivers/net/ethernet/renesas/rswitch.c > > @@ -156,22 +156,31 @@ static int rswitch_gwca_axi_ram_reset(struct rswitch_private *priv) > > return rswitch_reg_wait(priv->addr, GWARIRM, GWARIRM_ARR, GWARIRM_ARR); > > } > > > > -static void rswitch_gwca_set_rate_limit(struct rswitch_private *priv, int rate) > > +static void rswitch_gwca_set_rate_limit(struct rswitch_private *priv, > > + struct rswitch_gwca_queue *txq) > > { > > - u32 gwgrlulc, gwgrlc; > > + u64 period_ps; > > + unsigned long rate; > > + u32 gwrlc; > > Hi Shimoda-san, > > a minor not from my side: please use reverse xmas tree order - longest line > to shortest - for local variable declarations in networking code. > > unsigned long rate; > u64 period_ps; > u32 gwrlc; Thank you for your comment! I completely forgot that network driver should use reverse xmas tree order... JFYI, I found another way to improve the performance. So, I dropped this patch on v2 [1]. [1] https://lore.kernel.org/all/20230606085558.1708766-1-yoshihiro.shimoda.uh@renesas.com/ Best regards, Yoshihiro Shimoda > -- > pw-bot: cr
Powered by blists - more mailing lists