[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2023 11:03:31 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Paul Fertser <fercerpav@...il.com>
Cc: linux-wireless@...r.kernel.org, Felix Fietkau <nbd@....name>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Ryder Lee <ryder.lee@...iatek.com>,
Shayne Chen <shayne.chen@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>, Kalle Valo <kvalo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, Rani Hod <rani.hod@...il.com>,
stable@...r.kernel.org
Subject: Re: [PATCH] mt76: mt7615: do not advertise 5 GHz on first phy of
MT7615D (DBDC)
On Mon, Jun 05, 2023 at 10:34:07AM +0300, Paul Fertser wrote:
> On DBDC devices the first (internal) phy is only capable of using
> 2.4 GHz band, and the 5 GHz band is exposed via a separate phy object,
> so avoid the false advertising.
Hi Paul,
Can I clarify that the second object won't hit the logic change
below and thus be limited to 2GHz?
> Reported-by: Rani Hod <rani.hod@...il.com>
> Closes: https://github.com/openwrt/openwrt/pull/12361
> Fixes: 7660a1bd0c22 ("mt76: mt7615: register ext_phy if DBDC is detected")
> Cc: stable@...r.kernel.org
> Signed-off-by: Paul Fertser <fercerpav@...il.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> index 68e88224b8b1..ccedea7e8a50 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> @@ -128,12 +128,12 @@ mt7615_eeprom_parse_hw_band_cap(struct mt7615_dev *dev)
> case MT_EE_5GHZ:
> dev->mphy.cap.has_5ghz = true;
> break;
> - case MT_EE_2GHZ:
> - dev->mphy.cap.has_2ghz = true;
> - break;
> case MT_EE_DBDC:
> dev->dbdc_support = true;
> fallthrough;
> + case MT_EE_2GHZ:
> + dev->mphy.cap.has_2ghz = true;
> + break;
> default:
> dev->mphy.cap.has_2ghz = true;
> dev->mphy.cap.has_5ghz = true;
> --
> 2.34.1
>
>
Powered by blists - more mailing lists