netdev - Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 06 Jun 2023 11:15:42 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Geert Uytterhoeven" <geert@...ux-m68k.org>,
 "Naresh Kamboju" <naresh.kamboju@...aro.org>
Cc: "open list" <linux-kernel@...r.kernel.org>,
 linux-next <linux-next@...r.kernel.org>, lkft-triage@...ts.linaro.org,
 clang-built-linux <llvm@...ts.linux.dev>,
 Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
 "Linux ARM" <linux-arm-kernel@...ts.infradead.org>,
 Netdev <netdev@...r.kernel.org>, "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 "Anders Roxell" <anders.roxell@...aro.org>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>,
 "Maxime Coquelin" <mcoquelin.stm32@...il.com>, maxime.chevallier@...tlin.com,
 "Simon Horman" <simon.horman@...igine.com>
Subject: Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy

On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote:
> Hi Naresh,
>
> On Tue, Jun 6, 2023 at 10:53 AM Naresh Kamboju
> <naresh.kamboju@...aro.org> wrote:
>> On Tue, 6 Jun 2023 at 14:17, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
>> > Following build regressions found while building arm shmobile_defconfig on
>> > Linux next-20230606.
>> >
>> > Regressions found on arm:
>> >
>> >  - build/clang-16-shmobile_defconfig
>> >  - build/gcc-8-shmobile_defconfig
>> >  - build/gcc-12-shmobile_defconfig
>> >  - build/clang-nightly-shmobile_defconfig
>>
>> And mips defconfig builds failed.
>> Regressions found on mips:
>>
>>   - build/clang-16-defconfig
>>   - build/gcc-12-defconfig
>>   - build/gcc-8-defconfig
>>   - build/clang-nightly-defconfig
>
> Please give my fix a try:
> https://lore.kernel.org/linux-renesas-soc/7b36ac43778b41831debd5c30b5b37d268512195.1686039915.git.geert+renesas@glider.be
>

This won't work when PCS_LYNX is a loadable module and
STMMAC is built-in. I think we should just select PCS_LYNX
unconditionally from stmmac even if no front-end driver
using it is enabled.

I tried to come up with a way to move the dependency into
the altera specific front-end, but couldn't find an obvious
or simple way to do this.

Having a proper abstraction for PCS drivers instead of
directly calling into exported driver symbols might help
here, but that would add complexity elsewhere.

     Arnd