netdev - Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUH2Grrv6842YWXHDmd+O3iHdwqTVjYf8f1nbVRzGA+6w@mail.gmail.com>
Date: Tue, 6 Jun 2023 11:28:38 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, open list <linux-kernel@...r.kernel.org>, 
	linux-next <linux-next@...r.kernel.org>, lkft-triage@...ts.linaro.org, 
	clang-built-linux <llvm@...ts.linux.dev>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, 
	Linux ARM <linux-arm-kernel@...ts.infradead.org>, Netdev <netdev@...r.kernel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Anders Roxell <anders.roxell@...aro.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, maxime.chevallier@...tlin.com, 
	Simon Horman <simon.horman@...igine.com>
Subject: Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy

Hi Arnd,

On Tue, Jun 6, 2023 at 11:16 AM Arnd Bergmann <arnd@...db.de> wrote:
> On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote:
> > On Tue, Jun 6, 2023 at 10:53 AM Naresh Kamboju
> > <naresh.kamboju@...aro.org> wrote:
> >> On Tue, 6 Jun 2023 at 14:17, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
> >> > Following build regressions found while building arm shmobile_defconfig on
> >> > Linux next-20230606.
> >> >
> >> > Regressions found on arm:
> >> >
> >> >  - build/clang-16-shmobile_defconfig
> >> >  - build/gcc-8-shmobile_defconfig
> >> >  - build/gcc-12-shmobile_defconfig
> >> >  - build/clang-nightly-shmobile_defconfig
> >>
> >> And mips defconfig builds failed.
> >> Regressions found on mips:
> >>
> >>   - build/clang-16-defconfig
> >>   - build/gcc-12-defconfig
> >>   - build/gcc-8-defconfig
> >>   - build/clang-nightly-defconfig
> >
> > Please give my fix a try:
> > https://lore.kernel.org/linux-renesas-soc/7b36ac43778b41831debd5c30b5b37d268512195.1686039915.git.geert+renesas@glider.be
>
> This won't work when PCS_LYNX is a loadable module and
> STMMAC is built-in. I think we should just select PCS_LYNX

Oops, you're right, forgot about that case.
What about using IS_REACHABLE() instead?
No, that won't work either, as DWMAC_SOCFPGA can be modular,
with STMMAC builtin.

> unconditionally from stmmac even if no front-end driver
> using it is enabled.
>
> I tried to come up with a way to move the dependency into
> the altera specific front-end, but couldn't find an obvious
> or simple way to do this.
>
> Having a proper abstraction for PCS drivers instead of
> directly calling into exported driver symbols might help
> here, but that would add complexity elsewhere.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds