netdev - Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 11:44:46 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"David S . Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash

On Tue, Jun 06, 2023 at 09:30:12AM +0200, Eric Dumazet wrote:
> On Tue, Jun 6, 2023 at 12:52 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Fri,  2 Jun 2023 16:31:40 +0000 Eric Dumazet wrote:
> > > +             if (sk->sk_state == TCP_ESTABLISHED) {
> > > +                     /* This READ_ONCE() is paired with the WRITE_ONCE()
> > > +                      * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> > > +                      */
> > > +                     sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> > > +                     }
> >
> > Hi Eric, the series got "changes requested", a bit unclear why,
> > I'm guessing it's because it lacks Fixes tags.
> >
> > I also noticed that the closing bracket above looks misaligned.
> 
> Right I think Simon gave this feedback.

FWIWI, I think it was Kuniyuki.

> 
> >
> > Would you mind reposting? If you prefer not to add Fixes tag
> > a mention that it's intentional in the cover letter is enough.
> 
> Yes, I do not think a Fixes: tag is necessary.
> 
> I will post a v2 with an aligned closing bracket.
> 
> Thanks.
>