netdev - Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 09:43:00 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to sk->sk_rxhash

On Tue, Jun 6, 2023 at 9:30 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Tue, Jun 6, 2023 at 12:52 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Fri,  2 Jun 2023 16:31:40 +0000 Eric Dumazet wrote:
> > > +             if (sk->sk_state == TCP_ESTABLISHED) {
> > > +                     /* This READ_ONCE() is paired with the WRITE_ONCE()
> > > +                      * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> > > +                      */
> > > +                     sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> > > +                     }
> >
> > Hi Eric, the series got "changes requested", a bit unclear why,
> > I'm guessing it's because it lacks Fixes tags.
> >
> > I also noticed that the closing bracket above looks misaligned.
>
> Right I think Simon gave this feedback.

Oops, that was Kuniyuki

Kuniyuki, do you mind adding your Reviewed-by: tag that I forgot to add ?

>
> >
> > Would you mind reposting? If you prefer not to add Fixes tag
> > a mention that it's intentional in the cover letter is enough.
>
> Yes, I do not think a Fixes: tag is necessary.

I added them, because why not ;)