netdev - RE: [PATCH net v2 02/10] ice: Add driver support for firmware changes for LAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 16:59:16 +0000
From: "Ertman, David M" <david.m.ertman@...el.com>
To: Daniel Machon <daniel.machon@...rochip.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net v2 02/10] ice: Add driver support for firmware changes
 for LAG

> -----Original Message-----
> From: Daniel Machon <daniel.machon@...rochip.com>
> Sent: Tuesday, June 6, 2023 2:17 AM
> To: Ertman, David M <david.m.ertman@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Subject: Re: [PATCH net v2 02/10] ice: Add driver support for firmware
> changes for LAG
> 
>  > Add the defines, fields, and detection code for FW support of LAG for
> > SRIOV.  Also exposes some previously static functions to allow access
> > in the lag code.
> >
> > Clean up code that is unused or not needed for LAG support.  Also add
> > a ordered workqueue for processing LAG events.
> 
> nit: s/a/an/
> 

Change made.

> >
> > Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice.h          |  5 ++
> >  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  3 ++
> >  drivers/net/ethernet/intel/ice/ice_common.c   |  9 +++-
> >  drivers/net/ethernet/intel/ice/ice_lag.c      | 53 ++++++++++---------
> >  drivers/net/ethernet/intel/ice/ice_lib.c      |  2 +-
> >  drivers/net/ethernet/intel/ice/ice_lib.h      |  1 +
> >  drivers/net/ethernet/intel/ice/ice_main.c     | 12 +++++
> >  drivers/net/ethernet/intel/ice/ice_type.h     |  2 +
> >  8 files changed, 59 insertions(+), 28 deletions(-)
> >



> > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> > index 23a9f169bc71..fd21b5e38600 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_common.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> > @@ -2248,7 +2248,14 @@ ice_parse_common_caps(struct ice_hw *hw,
> struct ice_hw_common_caps *caps,
> >         case ICE_AQC_CAPS_TX_SCHED_TOPO_COMP_MODE:
> >                 caps->tx_sched_topo_comp_mode_en = (number == 1);
> >                 break;
> > -
> > +       case ICE_AQC_CAPS_FW_LAG_SUPPORT:
> > +               caps->roce_lag = !!(number & ICE_AQC_BIT_ROCEV2_LAG);
> > +               ice_debug(hw, ICE_DBG_INIT, "%s: roce_lag = %d\n",
> > +                         prefix, caps->roce_lag);
> > +               caps->sriov_lag = !!(number & ICE_AQC_BIT_SRIOV_LAG);
> > +               ice_debug(hw, ICE_DBG_INIT, "%s: sriov_lag = %d\n",
> > +                         prefix, caps->sriov_lag);
> > +               break;
> 
> roce_lag and sriov_lag are both u8 - should this be %u for unsigned int?
>

Change made.

Changes out with v3 of patches.
 
> >         default:
> >                 /* Not one of the recognized common capabilities */
> >                 found = false;