netdev - RE: [PATCH net v2 03/10] ice: changes to the interface with the HW and FW for SRIOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 18:11:30 +0000
From: "Ertman, David M" <david.m.ertman@...el.com>
To: Daniel Machon <daniel.machon@...rochip.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net v2 03/10] ice: changes to the interface with the HW
 and FW for SRIOV_VF+LAG

> -----Original Message-----
> From: Daniel Machon <daniel.machon@...rochip.com>
> Sent: Tuesday, June 6, 2023 2:37 AM
> To: Ertman, David M <david.m.ertman@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Subject: Re: [PATCH net v2 03/10] ice: changes to the interface with the HW
> and FW for SRIOV_VF+LAG
> 
> > Add defines needed for interaction with the FW admin queue interface
> > in relation to supporting LAG and SRIOV VFs interacting.
> >
> > Add code, or make non-static previously static functions, to access
> > the new and changed admin queue calls for LAG.
> >
> > Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> > ---
> >  .../net/ethernet/intel/ice/ice_adminq_cmd.h   | 50 +++++++++++-
> >  drivers/net/ethernet/intel/ice/ice_common.c   | 47 +++++++++++
> >  drivers/net/ethernet/intel/ice/ice_common.h   |  4 +
> >  drivers/net/ethernet/intel/ice/ice_sched.c    | 14 ++--
> >  drivers/net/ethernet/intel/ice/ice_sched.h    | 21 +++++
> >  drivers/net/ethernet/intel/ice/ice_switch.c   | 79 ++++++++++++++-----
> >  drivers/net/ethernet/intel/ice/ice_switch.h   | 26 ++++++
> >  7 files changed, 212 insertions(+), 29 deletions(-)
> >


> > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> > index fd21b5e38600..46b5de358a93 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_common.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> > @@ -4236,6 +4236,53 @@ ice_aq_dis_lan_txq(struct ice_hw *hw, u8
> num_qgrps,
> >         return status;
> >  }
> >
> > +/**
> > + * ice_aq_cfg_lan_txq
> > + * @hw: pointer to the hardware structure
> > + * @buf: buffer for command
> > + * @buf_size: size of buffer in bytes
> > + * @num_qs: number of qeueues being configured
> 
> nit s/qeueues/queues

Change made.

> 
> > + * @oldport: origination lport
> > + * @newport: destination lport


> > +       status = ice_aq_alloc_free_res(hw, 1, buf, buf_len,
> > +                                      ice_aqc_opc_share_res, NULL);
> > +
> > +       if (status)
> > +               ice_debug(hw, ICE_DBG_SW, "Could not set resource type %d id
> %d to %s\n",
> > +                         type, res_id, shared ? "SHARED" : "DEDICATED");
> 
> Likewise: type, res_id and shared are all unsigned here - consider %u.

Set type and res_id to %u, but shared is being used in a test to print a string.

Changes to come in v3 of patches.

> 
> > +
> > +       kfree(buf);
> > +       return status;