netdev - Re: [PATCH net 2/2] eth: ixgbe: fix the wake condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73c192f9-59b6-77c5-922c-2222b660623f@intel.com>
Date: Wed, 7 Jun 2023 09:33:14 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<jesse.brandeburg@...el.com>
Subject: Re: [PATCH net 2/2] eth: ixgbe: fix the wake condition



On 6/6/2023 6:08 PM, Jakub Kicinski wrote:
> Flip the netif_carrier_ok() condition in queue wake logic.
> When I moved it to inside __netif_txq_completed_wake()
> I missed negating it.
> 
> This made the condition ineffective and could probably
> lead to crashes.
> 
> Fixes: 301f227fc860 ("net: piggy back on the memory barrier in bql when waking queues")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

LGTM

Reviewed-by: Tony Nguyen <anthony.l.nguyen@...el.com>