netdev - Re: [PATCH net 1/2] eth: bnxt: fix the wake condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLik_YRgewhF=7McQK+iqe27qTpGtHoQNpJFUG10Esq=DOg@mail.gmail.com>
Date: Tue, 6 Jun 2023 21:34:45 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, David Wei <davidhwei@...a.com>
Subject: Re: [PATCH net 1/2] eth: bnxt: fix the wake condition

On Tue, Jun 6, 2023 at 6:08 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The down condition should be the negation of the wake condition,
> IOW when I moved it from:
>
>  if (cond && wake())
> to
>  if (__netif_txq_completed_wake(cond))
>
> Cond should have been negated. Flip it now.
>
> This bug leads to occasional crashes with netconsole.
> It may also lead to queue never waking up in case BQL is not enabled.
>
> Reported-by: David Wei <davidhwei@...a.com>
> Fixes: 08a096780d92 ("bnxt: use new queue try_stop/try_wake macros")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)