netdev - Re: [PATCH iwl-next] ice: clean up __ice_aq_get_set_rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 7 Jun 2023 22:38:43 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	intel-wired-lan@...ts.osuosl.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>,
	Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next] ice: clean up __ice_aq_get_set_rss_lut()

On Wed, Jun 07, 2023 at 09:42:28AM -0700, Jakub Kicinski wrote:
> On Wed, 7 Jun 2023 09:34:42 +0200 Simon Horman wrote:
> > > it's the same on gcc-13 on default (make M=...) settings, I think, I will
> > > post next version that is passing that build, even if to make integration
> > > with new gcc easier  
> > 
> > Thanks. TBH it does seem a bit silly to me.
> > But GCC builds failing does seem to be a problem that warrants being addressed.
> 
> Isn't GCC right? There's no guarantee that the value of @type in real,
> numerical sense falls within the set of values sanctioned by the enum.
> It is C after all, so enums are just decorated ints, aren't they?

Yes, of course you are right.