netdev - Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f05ef7a-479c-05a6-e38b-f792034c7afd@gmail.com>
Date: Wed, 7 Jun 2023 21:51:35 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com,
 edumazet@...gle.com, netdev@...r.kernel.org, habetsm.xilinx@...il.com
Subject: Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action
 offload

On 07/06/2023 05:56, Jakub Kicinski wrote:
> On Mon, 5 Jun 2023 20:17:38 +0100 edward.cree@....com wrote:
>> +			dev_hold(neigh->egdev = dst->dev);
> 
> Please use the ref-tracker enabled helpers in new code.

Fair point.  Guessing that applies to the netns reference as well?
(Though looking back I honestly can't remember why we need to hold
 the neigh->net reference for the life of efx_neigh_binder; but I
 presumably had some reason for it at the time and I'm leery of
 removing it now in case it's load-bearing.
 Chesterton's Fence and all that.)

> And the assignment on a separate line, please.

Will do.

-ed