netdev - Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230607160040.412fd9b2@kernel.org>
Date: Wed, 7 Jun 2023 16:00:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: edward.cree@....com, linux-net-drivers@....com, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
 habetsm.xilinx@...il.com
Subject: Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action
 offload

On Wed, 7 Jun 2023 21:51:35 +0100 Edward Cree wrote:
> Fair point.  Guessing that applies to the netns reference as well?

Yes. I should add that to the checker..

> (Though looking back I honestly can't remember why we need to hold
>  the neigh->net reference for the life of efx_neigh_binder; but I
>  presumably had some reason for it at the time and I'm leery of
>  removing it now in case it's load-bearing.
>  Chesterton's Fence and all that.)

You don't seem to be doing much with the reference, just holding it.
Your call.