[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<TYBPR01MB5341C785A741C9A2B07857ADD853A@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date: Wed, 7 Jun 2023 23:57:12 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Simon Horman <simon.horman@...igine.com>
CC: "s.shtylyov@....ru" <s.shtylyov@....ru>, "davem@...emloft.net"
<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
"maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net-next v3 2/2] net: renesas: rswitch: Use hardware pause
features
Hi Simon-san,
> From: Simon Horman, Sent: Thursday, June 8, 2023 12:24 AM
>
> On Wed, Jun 07, 2023 at 10:56:41AM +0900, Yoshihiro Shimoda wrote:
> > Since this driver used the "global rate limiter" feature of GWCA,
> > the TX perfromance of each port was reduced when multiple ports
>
> Hi Shimoda-san,
>
> a very minor nit, in case you have to do a v4 for some other reason:
>
> perfromance -> performance
Thank you for your review! I'll fix it on v4.
> > transmitted frames simultaneously. To improve perfromance, remove
>
> Here too.
I'll fix this too.
Best regards,
Yoshihiro Shimoda
> > the use of the "global rate limiter" feature and use "hardware pause"
> > features of the following:
> > - "per priority pause" of GWCA
> > - "global pause" of COMA
> >
> > Note that these features are not related to the ethernet PAUSE frame.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
>
> ...
Powered by blists - more mailing lists