netdev - Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIGWcLy8ivB6IeGK@corigine.com>
Date: Thu, 8 Jun 2023 10:50:56 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Eelco Chaudron <echaudro@...hat.com>
Cc: wangchuanlei <wangchuanlei@...pur.com>, aconole@...hat.com,
	dev@...nvswitch.org, netdev@...r.kernel.org, wangpeihui@...pur.com,
	kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net
Subject: Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter
 access before allocation

On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote:

...

> >> We moved the per cpu upcall counter allocation to the existing vport
> >> alloc and free functions to solve this.
> >>
> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on
> >> failure")
> >> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall
> >> packets")
> >> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
> >> ---
> >
> > Acked-by: Aaron Conole <aconole@...hat.com>
> 
> Were you intentionally ACKing this on Aaron’s behalf? Or just a cut/paste error ;)

I was wondering that too.
But then I concluded it was an artifact of top-posting or some
other behaviour of the mail client.