netdev - Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7tfs6w3eky.fsf@redhat.com>
Date: Mon, 12 Jun 2023 11:06:21 -0400
From: Aaron Conole <aconole@...hat.com>
To: Simon Horman <simon.horman@...igine.com>
Cc: Eelco Chaudron <echaudro@...hat.com>,  wangchuanlei
 <wangchuanlei@...pur.com>,  dev@...nvswitch.org,  netdev@...r.kernel.org,
  wangpeihui@...pur.com,  kuba@...nel.org,  pabeni@...hat.com,
  davem@...emloft.net
Subject: Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter
 access before allocation

Simon Horman <simon.horman@...igine.com> writes:

> On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote:
>
> ...
>
>> >> We moved the per cpu upcall counter allocation to the existing vport
>> >> alloc and free functions to solve this.
>> >>
>> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on
>> >> failure")
>> >> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall
>> >> packets")
>> >> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
>> >> ---
>> >
>> > Acked-by: Aaron Conole <aconole@...hat.com>
>> 
>> Were you intentionally ACKing this on Aaron’s behalf? Or just a cut/paste error ;)
>
> I was wondering that too.
> But then I concluded it was an artifact of top-posting or some
> other behaviour of the mail client.

Thankfully, I did ack the patch, but yes, this is something to be
careful.

To wangchuanlei <wangchuanlei@...pur.com>, please read

  https://people.kernel.org/tglx/

Specifically, do not top-post for this and other reasons.