netdev - RE: [PATCH v1 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3558494D2D38F58083233D80EC51A@BYAPR11MB3558.namprd11.prod.outlook.com>
Date: Fri, 9 Jun 2023 20:17:07 +0000
From: <Tristram.Ha@...rochip.com>
To: <simon.horman@...igine.com>
CC: <andrew@...n.ch>, <f.fainelli@...il.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v1 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs

> > +#define MII_LAN874X_PHY_PME1_SET             (2 << 13)
> > +#define MII_LAN874X_PHY_PME2_SET             (2 << 11)
> 
> Hi Tristram,
> 
> you could consider using GENMASK for the above.
>

The equivalent for (2 << 13) is BIT(14).
It is defined this way to reflect actual hardware register definition.
The value can be 0, 1, 2, 3 shifted to 13 and 11.