netdev - Re: [PATCH v1 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZIbQFq8szLsaT5kB@corigine.com>
Date: Mon, 12 Jun 2023 09:58:14 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Tristram.Ha@...rochip.com
Cc: andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
	netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs

On Fri, Jun 09, 2023 at 08:17:07PM +0000, Tristram.Ha@...rochip.com wrote:
> > > +#define MII_LAN874X_PHY_PME1_SET             (2 << 13)
> > > +#define MII_LAN874X_PHY_PME2_SET             (2 << 11)
> > 
> > Hi Tristram,
> > 
> > you could consider using GENMASK for the above.
> >
> 
> The equivalent for (2 << 13) is BIT(14).
> It is defined this way to reflect actual hardware register definition.
> The value can be 0, 1, 2, 3 shifted to 13 and 11.

Thanks, understood.