netdev - Re: [PATCH iwl-next v3 06/10] ice: Flesh out implementation of support for SRIOV on bonded interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 12 Jun 2023 09:23:45 +0200
From: Simon Horman <simon.horman@...igine.com>
To: "Ertman, David M" <david.m.ertman@...el.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"daniel.machon@...rochip.com" <daniel.machon@...rochip.com>
Subject: Re: [PATCH iwl-next v3 06/10] ice: Flesh out implementation of
 support for SRIOV on bonded interface

On Fri, Jun 09, 2023 at 04:32:27PM +0000, Ertman, David M wrote:

...

> > > +	/* find parent in primary tree */
> > > +	pi = hw->port_info;
> > > +	tc_node = ice_sched_get_tc_node(pi, tc);
> > > +	if (!tc_node) {
> > > +		dev_warn(dev, "Failure to find TC node in failover tree\n");
> > > +		goto resume_reclaim;
> > > +	}
> > > +
> > > +	aggnode = ice_sched_get_agg_node(pi, tc_node,
> > ICE_DFLT_AGG_ID);
> > > +	if (!aggnode) {
> > > +		dev_warn(dev, "Failure to find aggreagte node in failover
> > tree\n");
> > > +		goto resume_reclaim;
> > > +	}
> > > +
> > > +	aggl = ice_sched_get_agg_layer(hw);
> > > +	vsil = ice_sched_get_vsi_layer(hw);
> > > +
> > > +	for (n = aggl + 1; n < vsil; n++)
> > > +		num_nodes[n] = 1;
> > > +
> > > +	for (n = 0; n < aggnode->num_children; n++) {
> > > +		n_prt = ice_sched_get_free_vsi_parent(hw, aggnode-
> > >children[n],
> > > +						      num_nodes);
> > > +		if (n_prt)
> > > +			break;
> > > +	}
> > > +
> > > +	/* if no free parent found - add one */
> > > +	if (!n_prt) {
> > 
> > Likewise, here too.
> 
> Actually, this code was refactored out into a subfunction in patch 10/10 for
> this series.  In the subfunction, n_prt is initialized to NULL (for purposes of
> using it as a return value.  I need to move that refactoring back into this
> patch since there are multiple uses this far back.  Thanks for pointing this
> one out to me!
> 
> I will send this change out in patch set v4!

Thanks,

much appreciated.