netdev - Re: [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38dad5cb196741e56d018cea155982928694b2cc.camel@redhat.com>
Date: Mon, 12 Jun 2023 09:25:06 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jiri Pirko <jiri@...nulli.us>, Arkadiusz Kubalewski
	 <arkadiusz.kubalewski@...el.com>
Cc: kuba@...nel.org, vadfed@...a.com, jonathan.lemon@...il.com,
 corbet@....net,  davem@...emloft.net, edumazet@...gle.com, vadfed@...com, 
 jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, saeedm@...dia.com, 
 leon@...nel.org, richardcochran@...il.com, sj@...nel.org,
 javierm@...hat.com,  ricardo.canuelo@...labora.com, mst@...hat.com,
 tzimmermann@...e.de,  michal.michalik@...el.com,
 gregkh@...uxfoundation.org,  jacek.lawrynowicz@...ux.intel.com,
 airlied@...hat.com, ogabbay@...nel.org,  arnd@...db.de,
 nipun.gupta@....com, axboe@...nel.dk, linux@...y.sk,  masahiroy@...nel.org,
 benjamin.tissoires@...hat.com, geert+renesas@...der.be, 
 milena.olech@...el.com, kuniyu@...zon.com, liuhangbin@...il.com, 
 hkallweit1@...il.com, andy.ren@...cruise.com, razor@...ckwall.org, 
 idosch@...dia.com, lucien.xin@...il.com, nicolas.dichtel@...nd.com,
 phil@....cc,  claudiajkang@...il.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org,  netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org,  linux-rdma@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,  poros@...hat.com,
 mschmidt@...hat.com, linux-clk@...r.kernel.org,  vadim.fedorenko@...ux.dev
Subject: Re: [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base
 functions

On Sun, 2023-06-11 at 11:36 +0200, Jiri Pirko wrote:
> Fri, Jun 09, 2023 at 02:18:46PM CEST, arkadiusz.kubalewski@...el.com wrote:
> > From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> 
> [...]
> 
> > +int dpll_device_register(struct dpll_device *dpll, enum dpll_type type,
> > +			 const struct dpll_device_ops *ops, void *priv)
> > +{
> > +	struct dpll_device_registration *reg;
> > +	bool first_registration = false;
> > +
> > +	if (WARN_ON(!ops))
> > +		return -EINVAL;
> > +	if (WARN_ON(type < DPLL_TYPE_PPS || type > DPLL_TYPE_MAX))
> > +		return -EINVAL;
> > +
> > +	mutex_lock(&dpll_lock);
> > +	reg = dpll_device_registration_find(dpll, ops, priv);
> > +	if (reg) {
> > +		mutex_unlock(&dpll_lock);
> > +		return -EEXIST;
> > +	}
> > +
> > +	reg = kzalloc(sizeof(*reg), GFP_KERNEL);
> > +	if (!reg) {
> > +		mutex_unlock(&dpll_lock);
> > +		return -EEXIST;
> > +	}
> > +	reg->ops = ops;
> > +	reg->priv = priv;
> > +	dpll->type = type;
> > +	first_registration = list_empty(&dpll->registration_list);
> > +	list_add_tail(&reg->list, &dpll->registration_list);
> > +	if (!first_registration) {
> > +		mutex_unlock(&dpll_lock);
> > +		return 0;
> > +	}
> > +
> > +	xa_set_mark(&dpll_device_xa, dpll->id, DPLL_REGISTERED);
> > +	mutex_unlock(&dpll_lock);
> > +	dpll_device_create_ntf(dpll);
> 
> This function is introduced in the next patch. Breaks bissection. Make
> sure you can compile the code after every patch applied.

WRT, I think the easiest way to solve the above is adding the function
call in the next patch.

Cheers,

Paolo