netdev - Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Jun 2023 11:20:31 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Petr Machata <petrm@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, kernel@...gutronix.de, vadimp@...dia.com
Subject: Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's
 .probe()

On Mon, Jun 12, 2023 at 09:22:22AM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Ido Schimmel <idosch@...dia.com>
Tested-by: Ido Schimmel <idosch@...dia.com>

I assume it's intended for net-next.

> ---
>  drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> index 2c586c2308ae..41298835a11e 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> @@ -751,7 +751,7 @@ static void mlxsw_i2c_remove(struct i2c_client *client)
>  
>  int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)
>  {
> -	i2c_driver->probe_new = mlxsw_i2c_probe;
> +	i2c_driver->probe = mlxsw_i2c_probe;
>  	i2c_driver->remove = mlxsw_i2c_remove;
>  	return i2c_add_driver(i2c_driver);
>  }
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> -- 
> 2.39.2
>