netdev - Re: [RFC PATCH v2 1/4] net: wire up support for file_operations->uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b5e5988-3dc7-f5d6-e447-397696c0d533@kernel.org>
Date: Wed, 14 Jun 2023 08:15:10 -0700
From: David Ahern <dsahern@...nel.org>
To: Breno Leitao <leitao@...ian.org>, io-uring@...r.kernel.org,
 axboe@...nel.dk, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, Matthieu Baerts <matthieu.baerts@...sares.net>,
 Mat Martineau <martineau@...nel.org>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
 Xin Long <lucien.xin@...il.com>
Cc: leit@...com, asml.silence@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, dccp@...r.kernel.org, mptcp@...ts.linux.dev,
 linux-sctp@...r.kernel.org, ast@...nel.org, kuniyu@...zon.com,
 martin.lau@...nel.org, Jason Xing <kernelxing@...cent.com>,
 Joanne Koong <joannelkoong@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Jason A. Donenfeld" <Jason@...c4.com>, Willem de Bruijn
 <willemb@...gle.com>, Guillaume Nault <gnault@...hat.com>,
 Andrea Righi <andrea.righi@...onical.com>
Subject: Re: [RFC PATCH v2 1/4] net: wire up support for
 file_operations->uring_cmd()

On 6/14/23 5:07 AM, Breno Leitao wrote:
> diff --git a/include/linux/net.h b/include/linux/net.h
> index 8defc8f1d82e..58dea87077af 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -182,6 +182,8 @@ struct proto_ops {
>  	int	 	(*compat_ioctl) (struct socket *sock, unsigned int cmd,
>  				      unsigned long arg);
>  #endif
> +	int		(*uring_cmd)(struct socket *sock, struct io_uring_cmd *cmd,
> +				     unsigned int issue_flags);
>  	int		(*gettstamp) (struct socket *sock, void __user *userstamp,
>  				      bool timeval, bool time32);
>  	int		(*listen)    (struct socket *sock, int len);
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 62a1b99da349..a49b8b19292b 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -111,6 +111,7 @@ typedef struct {
>  struct sock;
>  struct proto;
>  struct net;
> +struct io_uring_cmd;
>  
>  typedef __u32 __bitwise __portpair;
>  typedef __u64 __bitwise __addrpair;
> @@ -1259,6 +1260,9 @@ struct proto {
>  
>  	int			(*ioctl)(struct sock *sk, int cmd,
>  					 int *karg);
> +	int			(*uring_cmd)(struct sock *sk,
> +					     struct io_uring_cmd *cmd,
> +					     unsigned int issue_flags);
>  	int			(*init)(struct sock *sk);
>  	void			(*destroy)(struct sock *sk);
>  	void			(*shutdown)(struct sock *sk, int how);
> @@ -1934,6 +1938,8 @@ int sock_common_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
>  			int flags);
>  int sock_common_setsockopt(struct socket *sock, int level, int optname,
>  			   sockptr_t optval, unsigned int optlen);
> +int sock_common_uring_cmd(struct socket *sock, struct io_uring_cmd *cmd,
> +			  unsigned int issue_flags);
>  
>  void sk_common_release(struct sock *sk);
>  
> diff --git a/net/core/sock.c b/net/core/sock.c
> index 1df7e432fec5..339fa74db60f 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -3668,6 +3668,18 @@ int sock_common_setsockopt(struct socket *sock, int level, int optname,
>  }
>  EXPORT_SYMBOL(sock_common_setsockopt);
>  
> +int sock_common_uring_cmd(struct socket *sock, struct io_uring_cmd *cmd,
> +			  unsigned int issue_flags)
> +{
> +	struct sock *sk = sock->sk;
> +
> +	if (!sk->sk_prot || !sk->sk_prot->uring_cmd)
> +		return -EOPNOTSUPP;
> +
> +	return sk->sk_prot->uring_cmd(sk, cmd, issue_flags);
> +}
> +EXPORT_SYMBOL(sock_common_uring_cmd);
> +

io_uring is just another in-kernel user of sockets. There is no reason
for io_uring references to be in core net code. It should be using
exposed in-kernel APIs and doing any translation of its op codes in
io_uring/  code.