netdev - Re: [PATCH iwl-next 0/2] iavf: make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7a4091b-01fa-9c91-1371-e3e703f2d4f3@intel.com>
Date: Thu, 15 Jun 2023 11:53:17 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Ahmed Zaki <ahmed.zaki@...el.com>, "Maciej
 Fijalkowski" <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH iwl-next 0/2] iavf: make some functions static

On 6/14/23 19:27, Tony Nguyen wrote:
> On 6/13/2023 7:12 AM, Przemek Kitszel wrote:
>> Make static functions that are used in just one translation unit.
>> Remove all unused and unexported functions.
> 
> This doesn't apply.

Indeed it does not, I will repost mentioning prereq commits form yours 
dev-queue


> 
>> Przemek Kitszel (2):
>>    iavf: remove some unused functions and pointless wrappers
>>    iavf: make functions static where possible
>>
>>   drivers/net/ethernet/intel/iavf/iavf.h        | 10 -----
>>   drivers/net/ethernet/intel/iavf/iavf_alloc.h  |  3 +-
>>   drivers/net/ethernet/intel/iavf/iavf_common.c | 45 -------------------
>>   drivers/net/ethernet/intel/iavf/iavf_main.c   | 34 ++++++--------
>>   drivers/net/ethernet/intel/iavf/iavf_osdep.h  |  9 ----
>>   .../net/ethernet/intel/iavf/iavf_prototype.h  |  5 ---
>>   drivers/net/ethernet/intel/iavf/iavf_txrx.c   | 43 +++++++++---------
>>   drivers/net/ethernet/intel/iavf/iavf_txrx.h   |  4 --
>>   8 files changed, 35 insertions(+), 118 deletions(-)
>>