netdev - Re: [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230615093111.0ee762e4@kernel.org>
Date: Thu, 15 Jun 2023 09:31:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>,
 "vadfed@...a.com" <vadfed@...a.com>, "jonathan.lemon@...il.com"
 <jonathan.lemon@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "corbet@....net" <corbet@....net>, "davem@...emloft.net"
 <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "vadfed@...com" <vadfed@...com>, "Brandeburg, Jesse"
 <jesse.brandeburg@...el.com>, "Nguyen, Anthony L"
 <anthony.l.nguyen@...el.com>, "M, Saeed" <saeedm@...dia.com>,
 "leon@...nel.org" <leon@...nel.org>, "richardcochran@...il.com"
 <richardcochran@...il.com>, "sj@...nel.org" <sj@...nel.org>,
 "javierm@...hat.com" <javierm@...hat.com>, "ricardo.canuelo@...labora.com"
 <ricardo.canuelo@...labora.com>, "mst@...hat.com" <mst@...hat.com>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>, "Michalik, Michal"
 <michal.michalik@...el.com>, "gregkh@...uxfoundation.org"
 <gregkh@...uxfoundation.org>, "jacek.lawrynowicz@...ux.intel.com"
 <jacek.lawrynowicz@...ux.intel.com>, "airlied@...hat.com"
 <airlied@...hat.com>, "ogabbay@...nel.org" <ogabbay@...nel.org>,
 "arnd@...db.de" <arnd@...db.de>, "nipun.gupta@....com"
 <nipun.gupta@....com>, "axboe@...nel.dk" <axboe@...nel.dk>, "linux@...y.sk"
 <linux@...y.sk>, "masahiroy@...nel.org" <masahiroy@...nel.org>,
 "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
 "geert+renesas@...der.be" <geert+renesas@...der.be>, "Olech, Milena"
 <milena.olech@...el.com>, "kuniyu@...zon.com" <kuniyu@...zon.com>,
 "liuhangbin@...il.com" <liuhangbin@...il.com>, "hkallweit1@...il.com"
 <hkallweit1@...il.com>, "andy.ren@...cruise.com" <andy.ren@...cruise.com>,
 "razor@...ckwall.org" <razor@...ckwall.org>, "idosch@...dia.com"
 <idosch@...dia.com>, "lucien.xin@...il.com" <lucien.xin@...il.com>,
 "nicolas.dichtel@...nd.com" <nicolas.dichtel@...nd.com>, "phil@....cc"
 <phil@....cc>, "claudiajkang@...il.com" <claudiajkang@...il.com>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
 "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, poros <poros@...hat.com>, mschmidt
 <mschmidt@...hat.com>, "linux-clk@...r.kernel.org"
 <linux-clk@...r.kernel.org>, "vadim.fedorenko@...ux.dev"
 <vadim.fedorenko@...ux.dev>
Subject: Re: [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem
 interface

On Thu, 15 Jun 2023 12:18:28 +0200 Jiri Pirko wrote:
> Yeah, that is what we had originally. This just pushes out the
> different attr selection from the nest one level up to the actualy
> nesting attribute.

Oh no, no extra nesting. Let me try to fake up the output:

'pin': [{
 {'clock-id': 282574471561216,
  'module-name': 'ice',
  'pin-dpll-caps': 4,
  'pin-id': 13,
  'parent-device': [{'pin-id': 2, 'pin-state': 'connected'},
                    {'pin-id': 3, 'pin-state': 'disconnected'}],
  'parent-pin': [{'id': 0, 'pin-direction': 'input'},
                 {'id': 1, 'pin-direction': 'input'}],
  'pin-type': 'synce-eth-port'}
}]

> One downside of this is you will have 2 arrays of parent objects,
> one per parent type. Current code neatly groups them into a single array.
> 
> I guess this is a matter of personal preference, I'm fine either way.

Yeah, could be.