netdev - Re: [PATCH v7 0/9] fix fwnode_irq_get[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 16 Jun 2023 14:45:06 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Daniel Scally <djrscally@...il.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Wolfram Sang <wsa@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Andreas Klinger <ak@...klinger.de>,
 Marcin Wojtas <mw@...ihalf.com>, Russell King <linux@...linux.org.uk>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Jonathan Neuschäfer
 <j.neuschaefer@....net>, Linus Walleij <linus.walleij@...aro.org>,
 Paul Cercueil <paul@...pouillou.net>, Akhil R <akhilrajeev@...dia.com>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-iio@...r.kernel.org,
 netdev@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linux-gpio@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v7 0/9] fix fwnode_irq_get[_byname()] returnvalue

On 6/15/23 14:37, Greg Kroah-Hartman wrote:
> On Tue, May 30, 2023 at 11:34:38PM -0700, Jakub Kicinski wrote:
>> On Mon, 29 May 2023 09:22:15 +0300 Matti Vaittinen wrote:
>>> The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned
>>> zero if mapping the IRQ fails. This contradicts the
>>> fwnode_irq_get_byname() documentation. Furthermore, returning zero or
>>> errno on error is unepected and can easily lead to problems
>>> like.
>>
>> What's the merging plan? Could patch 1 go to a stable branch
>> and then driver trees can pull it in and apply their respective
>> patches locally?
> 
> I'll take patch 1 now, and then after 6.5-rc1, Matti, can you send the
> cleanup patches to the respective subsystems?

Yes. I can re-spin the rest of the patches.

Yours,
	-- Matti

> 
> thanks,
> 
> greg k-h

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~