netdev - Re: [PATCH v2 12/12] kprobes: remove dependcy on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0qbmy14.fsf@all.your.base.are.belong.to.us>
Date: Fri, 16 Jun 2023 13:44:55 +0200
From: Björn Töpel <bjorn@...nel.org>
To: Mike Rapoport <rppt@...nel.org>, linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>, Catalin Marinas
 <catalin.marinas@....com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S. Miller" <davem@...emloft.net>, Dinh Nguyen
 <dinguyen@...nel.org>, Heiko Carstens <hca@...ux.ibm.com>, Helge Deller
 <deller@....de>, Huacai Chen <chenhuacai@...nel.org>, Kent Overstreet
 <kent.overstreet@...ux.dev>, Luis Chamberlain <mcgrof@...nel.org>, Mark
 Rutland <mark.rutland@....com>, Michael Ellerman <mpe@...erman.id.au>,
 Mike Rapoport <rppt@...nel.org>, Nadav Amit <nadav.amit@...il.com>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>, Palmer Dabbelt
 <palmer@...belt.com>, Puranjay Mohan <puranjay12@...il.com>, Rick
 Edgecombe <rick.p.edgecombe@...el.com>, Russell King
 <linux@...linux.org.uk>, Song Liu <song@...nel.org>, Steven Rostedt
 <rostedt@...dmis.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Thomas Gleixner <tglx@...utronix.de>, Will Deacon <will@...nel.org>,
 bpf@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mips@...r.kernel.org, linux-mm@...ck.org,
 linux-modules@...r.kernel.org, linux-parisc@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 loongarch@...ts.linux.dev, netdev@...r.kernel.org,
 sparclinux@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2 12/12] kprobes: remove dependcy on CONFIG_MODULES

Mike Rapoport <rppt@...nel.org> writes:

> From: "Mike Rapoport (IBM)" <rppt@...nel.org>
>
> kprobes depended on CONFIG_MODULES because it has to allocate memory for
> code.

I think you can remove the MODULES dependency from BPF_JIT as well:

--8<--
diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
index 2dfe1079f772..fa4587027f8b 100644
--- a/kernel/bpf/Kconfig
+++ b/kernel/bpf/Kconfig
@@ -41,7 +41,6 @@ config BPF_JIT
        bool "Enable BPF Just In Time compiler"
        depends on BPF
        depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
-       depends on MODULES
        help
          BPF programs are normally handled by a BPF interpreter. This option
          allows the kernel to generate native code when a program is loaded
--8<--

Björn