netdev - Re: [PATCH v1] net: mctp: remove redundant RTN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 17 Jun 2023 10:49:19 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Lin Ma <linma@....edu.cn>, matt@...econstruct.com.au,
 davem@...emloft.net,  edumazet@...gle.com, kuba@...nel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1] net: mctp: remove redundant RTN_UNICAST check

Hi Lin,

> Current mctp_newroute() contains two exactly same check against
> rtm->rtm_type
> 
> static int mctp_newroute(...)
> {
> ...
>     if (rtm->rtm_type != RTN_UNICAST) { // (1)
>         NL_SET_ERR_MSG(extack, "rtm_type must be RTN_UNICAST");
>         return -EINVAL;
>     }
> ...
>     if (rtm->rtm_type != RTN_UNICAST) // (2)
>         return -EINVAL;
> ...
> }
> 
> This commits removes the (2) check as it is redundant.

Looks good, thanks!

Acked-by: Jeremy Kerr <jk@...econstruct.com.au>

(but this probably doesn't need to go into the net fixes tree; net-next
would be fine.)

Cheers,


Jeremy