netdev - Re: [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230616235651.58b9519c@kernel.org>
Date: Fri, 16 Jun 2023 23:56:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, pavan.kumar.linga@...el.com,
 emil.s.tantilov@...el.com, jesse.brandeburg@...el.com,
 sridhar.samudrala@...el.com, shiraz.saleem@...el.com,
 sindhu.devale@...el.com, willemb@...gle.com, decot@...gle.com,
 andrew@...n.ch, leon@...nel.org, mst@...hat.com, simon.horman@...igine.com,
 shannon.nelson@....com, stephen@...workplumber.org
Subject: Re: [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF
 driver

On Fri, 16 Jun 2023 16:13:26 -0700 Tony Nguyen wrote:
> v3:
> Patch 5:
>  * instead of void, used 'struct virtchnl2_create_vport' type for
>    vport_params_recvd and vport_params_reqd and removed the typecasting
>  * used u16/u32 as needed instead of int for variables which cannot be
>    negative and updated in all the places whereever applicable
> Patch 6:
>  * changed the commit message to "add ptypes and MAC filter support"
>  * used the sender Signed-off-by as the last tag on all the patches
>  * removed unnecessary variables 0-init
>  * instead of fixing the code in this commit, fixed it in the commit
>    where the change was introduced first
>  * moved get_type_info struct on to the stack instead of memory alloc
>  * moved mutex_lock and ptype_info memory alloc outside while loop and
>    adjusted the return flow
>  * used 'break' instead of 'continue' in ptype id switch case

Ah, missed this, busy times.
Luckily I commented on different patches than the ones that changed.
-- 
pw-bot: cr