netdev - Re: [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bbbf0ca-4f32-ee62-5d49-b53a07e62055@intel.com>
Date: Wed, 21 Jun 2023 12:13:06 -0700
From: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, <emil.s.tantilov@...el.com>,
	<jesse.brandeburg@...el.com>, <sridhar.samudrala@...el.com>,
	<shiraz.saleem@...el.com>, <sindhu.devale@...el.com>, <willemb@...gle.com>,
	<decot@...gle.com>, <andrew@...n.ch>, <leon@...nel.org>, <mst@...hat.com>,
	<simon.horman@...igine.com>, <shannon.nelson@....com>,
	<stephen@...workplumber.org>
Subject: Re: [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF
 driver



On 6/16/2023 11:56 PM, Jakub Kicinski wrote:
> On Fri, 16 Jun 2023 16:13:26 -0700 Tony Nguyen wrote:
>> v3:
>> Patch 5:
>>   * instead of void, used 'struct virtchnl2_create_vport' type for
>>     vport_params_recvd and vport_params_reqd and removed the typecasting
>>   * used u16/u32 as needed instead of int for variables which cannot be
>>     negative and updated in all the places whereever applicable
>> Patch 6:
>>   * changed the commit message to "add ptypes and MAC filter support"
>>   * used the sender Signed-off-by as the last tag on all the patches
>>   * removed unnecessary variables 0-init
>>   * instead of fixing the code in this commit, fixed it in the commit
>>     where the change was introduced first
>>   * moved get_type_info struct on to the stack instead of memory alloc
>>   * moved mutex_lock and ptype_info memory alloc outside while loop and
>>     adjusted the return flow
>>   * used 'break' instead of 'continue' in ptype id switch case
> 
> Ah, missed this, busy times.
> Luckily I commented on different patches than the ones that changed.

Thanks for the feedback. Given the timing and type of changes requested 
for the patches, would it be possible to accept this patch series (v3) 
in its current form, as we continue to develop and address all the 
feedback in followup patches?