netdev - Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fd76d67-0839-1b82-5b6a-d3fc75a240f8@ti.com>
Date: Mon, 19 Jun 2023 14:49:40 -0500
From: "Bajjuri, Praneeth" <praneeth@...com>
To: Andrew Lunn <andrew@...n.ch>, Francesco Dolcini <francesco@...cini.it>,
        Siddharth Vadapalli <s-vadapalli@...com>
CC: Heiner Kallweit <hkallweit1@...il.com>,
        Russell King
	<linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
        Francesco Dolcini
	<francesco.dolcini@...adex.com>,
        Geet Modi <geet.modi@...com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and
 retain established link"



On 6/19/2023 11:30 AM, Andrew Lunn wrote:
> On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@...adex.com>
>>
>> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>>
>> This fixes a regression in which the link would come up, but no
>> communication was possible.
>>
>> The reverted commit was also removing a comment about
>> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
>> since it seems that this is unrelated to the original code change.
>>
>> Cc: Praneeth Bajjuri <praneeth@...com>
>> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
>> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> There has been plenty of time given for somebody to investigate this
> regression, and nothing has happened. So i agree, lets revert it.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Agreed to revert.

Reviewed-by: Praneeth Bajjuri <praneeth@...com>


> 
>      Andrew