netdev - Re: [PATCH net-next] net/mlx5: Fix error code in mlx5_is_reset_now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Jun 2023 19:59:11 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Moshe Shemesh <moshe@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, 
	Leon Romanovsky <leon@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Shay Drory <shayd@...dia.com>, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: Fix error code in mlx5_is_reset_now_capable()

On Tue, Jun 20, 2023 at 7:13 PM Dan Carpenter <dan.carpenter@...aro.org>
wrote:

> The mlx5_is_reset_now_capable() function returns bool, not negative
> error codes.  So if fast teardown is not supported it should return
> false instead of -EOPNOTSUPP.
>
> Fixes: 92501fa6e421 ("net/mlx5: Ack on sync_reset_request only if PF can
> do reset_now")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
> b/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
> index 7af2b14ab5d8..fb7874da3caa 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
> @@ -327,7 +327,7 @@ static bool mlx5_is_reset_now_capable(struct
> mlx5_core_dev *dev)
>
>         if (!MLX5_CAP_GEN(dev, fast_teardown)) {
>                 mlx5_core_warn(dev, "fast teardown is not supported by
> firmware\n");
> -               return -EOPNOTSUPP;
> +               return false;
>         }
>
>         err = pci_read_config_word(dev->pdev, PCI_DEVICE_ID, &dev_id);
> --
> 2.39.2
>
>

-- 
Regards,
Kalesh A P

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)