netdev - Re: [net-next PATCH v5 3/3] leds: trigger: netdev: expose hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nNxxw=sMuj1FMwTCWcMwPTGeWm8Vi90CuqDL4y6Sy9PoQ@mail.gmail.com>
Date: Tue, 20 Jun 2023 19:55:55 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Dan Carpenter <dan.carpenter@...aro.org>, 
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [net-next PATCH v5 3/3] leds: trigger: netdev: expose hw_control
 status via sysfs

On Tue, Jun 20, 2023 at 6:51 PM Andrew Lunn <andrew@...n.ch> wrote:

> >     +static ssize_t hw_control_show(struct device *dev,
> >     +                              struct device_attribute *attr, char
> *buf)
> >     +{
> >     +       struct led_netdev_data *trigger_data =
> led_trigger_get_drvdata
> >     (dev);
> >     +
> >     +       return sprintf(buf, "%d\n", trigger_data->hw_control);
> >
> > [Kalesh]: How about using sysfs_emit?
>
> Currently, there are zero instances of sysfs_emit() in ledtrig-netdev,
> and in any files in drivers/leds/trigger/, or even drivers/leds.
>
> So i think it would be better to keep this consistent with the rest of
> the code in this file, and have a follow up patchset which reviews and
> converts the 52 sprintf() in drivers/leds.
>
Sounds good, thank you

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

>
>          Andrew
>


-- 
Regards,
Kalesh A P

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)