[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b0a61cf4-adb1-4261-b6a5-aeb1e3c1b1aa@lunn.ch>
Date: Tue, 20 Jun 2023 15:29:04 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Guo Samin <samin.guo@...rfivetech.com>
Cc: Conor Dooley <conor@...nel.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, netdev@...r.kernel.org,
Peter Geis <pgwipeout@...il.com>, Frank <Frank.Sae@...or-comm.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver
strength cfg
> I just got the detailed data of Driver Strength(DS) from Motorcomm ,
> which applies to both rx_clk and rx_data.
>
> |----------------------|
> | ds map table |
> |----------------------|
> | DS(3b) | Current (mA)|
> |--------|-------------|
> | 000 | 1.20 |
> | 001 | 2.10 |
> | 010 | 2.70 |
> | 011 | 2.91 |
> | 100 | 3.11 |
> | 101 | 3.60 |
> | 110 | 3.97 |
> | 111 | 4.35 |
> |--------|-------------|
>
> Since these currents are not integer values
Integers is not a problem. Simply use uA.
> and have no regularity, it is not very good to use in the drive/dts
> in my opinion.
I think they are fine to use. Add a lookup table, microamps to
register value. Return -EINVAL if the requested value is not in the
table. List the valid values in the schema, so the checker tool might
point out problems.
Andrew
Powered by blists - more mailing lists