netdev - Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <054c180f-9fab-c849-0971-1b8b9a89fb9b@inbox.ru>
Date: Thu, 22 Jun 2023 21:48:19 +0300
From: Maxim Kochetkov <fido_max@...ox.ru>
To: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, "Simek, Michal" <michal.simek@....com>,
 Andrew Lunn <andrew@...n.ch>, Robert Hancock <robert.hancock@...ian.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

On 22.06.2023 21:43, Pandey, Radhey Shyam wrote:

>> DMA detection will fail if axinet was started before (by boot loader,
> 
> :%s/axinet/axienet/g
Sorry about that. I will fix it in v3.

> 
>> boot ROM, etc). In this state axinet will not start properly.
>> XAXIDMA_TX_CDESC_OFFSET + 4 register (MM2S_CURDESC_MSB) is used to
>> detect
>> 64 DMA capability here. But datasheet says: When DMACR.RS is 1
>> (axinet is in enabled state), CURDESC_PTR becomes Read Only (RO) and
>> is used to fetch the first descriptor. So iowrite32()/ioread32() trick
>> to this register to detect DMA will not work.
>> So move axinet reset before DMA detection.
>>
>> Fixes: 04cc2da39698 ("net: axienet: reset core on initialization prior to MDIO
> 
> Is this fixes tag correct ? I think the failure is introduced after
> f735c40ed93c net: axienet: Autodetect 64-bit DMA capability?

Yes of course. I will fix it in v3.