netdev - Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2cd7370-6c42-724d-fe03-49debc566346@inbox.ru>
Date: Thu, 22 Jun 2023 22:23:25 +0300
From: Maxim Kochetkov <fido_max@...ox.ru>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Radhey Shyam Pandey
 <radhey.shyam.pandey@....com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Michal Simek <michal.simek@....com>,
 Robert Hancock <robert.hancock@...ian.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

On 22.06.2023 22:18, Andrew Lunn wrote:
>> +	/* Reset core now that clocks are enabled, prior to accessing MDIO */
>> +	ret = __axienet_device_reset(lp);
>> +	if (ret)
>> +		goto cleanup_clk;
>> +
>>   	/* Autodetect the need for 64-bit DMA pointers.
> 
> I would say the comment is now not fully correct. It probably should
> be extended to include 64 bit DMA.

Fixed in v4